Fix compilation warnings related to unchecked return values

Check return results from read/write

Also added EINTR handling and cleaned up use of
ASSERT_EQ(expected, actual) macro

Signed-off-by: Chris Dearman <chris@mips.com>

[Ted Mielczarek]

Not sure if mail got sent here.

[Ben Chan]

http://breakpad.appspot.com/377001/diff/1/src/client/linux/minidump_writer/li...
File src/client/linux/minidump_writer/line_reader_unittest.cc (right):

http://breakpad.appspot.com/377001/diff/1/src/client/linux/minidump_writer/li...
src/client/linux/minidump_writer/line_reader_unittest.cc:73: ASSERT_EQ(write(fd,
"a\n", 2), 2);
1. ASSERT_EQ(expected, actual);
2. HANDLE_EINTR(write(...))

http://breakpad.appspot.com/377001/diff/1/src/client/linux/minidump_writer/li...
File src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc (right):

http://breakpad.appspot.com/377001/diff/1/src/client/linux/minidump_writer/li...
src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc:225:
ASSERT_EQ(read(fds[0], &junk, sizeof(junk)), sizeof(junk));
1. ASSERT_EQ(expected, actual)
2. HANDLE_EINTR(read(...))

http://breakpad.appspot.com/377001/diff/1/src/client/linux/minidump_writer/mi...
File src/client/linux/minidump_writer/minidump_writer_unittest.cc (right):

http://breakpad.appspot.com/377001/diff/1/src/client/linux/minidump_writer/mi...
src/client/linux/minidump_writer/minidump_writer_unittest.cc:341:
ASSERT_EQ(read(fds[0], &junk, sizeof(junk)), sizeof(junk));
1. ASSERT_EQ(expected, actual)
2. HANDLE_EINTR(read(...))

[chrisdearman]

Ben,
Thanks for the comments. I've uploaded a new version of the patch that fixes the
issues you pointed out. I also fixed the other uses of ASSERT_EQ that were
reversed.

[Ben Chan]

On 2012/04/16 22:17:28, chrisdearman wrote:
> Ben,
> Thanks for the comments. I've uploaded a new version of the patch that fixes
the
> issues you pointed out. I also fixed the other uses of ASSERT_EQ that were
> reversed.

lgtm

[Ben Chan]

Chris, looks like this patch has been committed @r957.  Could you close this
issue? Thanks.

On 2012/04/17 16:09:05, Ben Chan wrote:
> On 2012/04/16 22:17:28, chrisdearman wrote:
> > Ben,
> > Thanks for the comments. I've uploaded a new version of the patch that fixes
> the
> > issues you pointed out. I also fixed the other uses of ASSERT_EQ that were
> > reversed.
> 
> lgtm