Support for .raSearch in the x86 stack walker

Support for .raSearch in the x86 stack walker

[Ted Mielczarek]

This could definitely use a unit test. You can probably start with one of the
existing ones and just modify it to match the data you're seeing in practice:
http://code.google.com/p/google-breakpad/source/browse/trunk/src/processor/st...

http://breakpad.appspot.com/349003/diff/1/src/google_breakpad/processor/stack...
File src/google_breakpad/processor/stackwalker.h (right):

http://breakpad.appspot.com/349003/diff/1/src/google_breakpad/processor/stack...
src/google_breakpad/processor/stackwalker.h:124: int searchwords = 30) {
Google styleguide prohibits default params. Maybe make kRASearchWords a class
static constant?

http://breakpad.appspot.com/349003/diff/1/src/processor/stackwalker_x86.cc
File src/processor/stackwalker_x86.cc (right):

http://breakpad.appspot.com/349003/diff/1/src/processor/stackwalker_x86.cc#ne...
src/processor/stackwalker_x86.cc:210: last_frame_info->saved_register_size;
You should fix the indentation here (unless your diff is just ignoring the
whitespace change).

http://breakpad.appspot.com/349003/diff/1/src/processor/stackwalker_x86.cc#ne...
src/processor/stackwalker_x86.cc:213: // the stack was aligned to a quadword
boundary.
Mark keeps telling me that comments should be written in third-person, FWIW.

http://breakpad.appspot.com/349003/diff/1/src/processor/stackwalker_x86.cc#ne...
src/processor/stackwalker_x86.cc:217: // but making them the same seems to work
well in practice.
Just drop the XXX here.

[Ted Mielczarek]

LGTM

http://breakpad.appspot.com/349003/diff/4001/src/google_breakpad/processor/st...
File src/google_breakpad/processor/stackwalker.h (right):

http://breakpad.appspot.com/349003/diff/4001/src/google_breakpad/processor/st...
src/google_breakpad/processor/stackwalker.h:115: {
Opening brace goes on the previous line.

[Mark Mentovai]

Committed r927