Issue 345001: Fix test addresses to use uintptr_t instead of u_int64_t.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 345001: Fix test addresses to use uintptr_t instead of u_int64_t. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by Michael Krebs

Modified:
12 years, 7 months ago

Reviewers:
Ben Chan, Lei Zhang (chromium), Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix test addresses to use uintptr_t instead of u_int64_t.

When a variable is used to set (and lookup) MappingInfo's "start_addr"
field, it needs to match types -- which is "uintptr_t".  When Chrome OS
updated the 'make' that's used for building, the 32-bit "char *" had
sign-extended when cast up to a u_int64_t -- maybe because pointers were
unsigned before and then changed to be signed -- and that caused the address
lookup to fail.

BUG=chromium-os:25355
TEST=Ran Breakpad unittests

Patch Set 1 #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/client/linux/handler/exception_handler_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/client/linux/minidump_writer/minidump_writer_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Michael Krebs

This fixes a unittest that failed when building for Chrome OS. Assuming this change is ...

12 years, 10 months ago #1

Ben Chan

On 2012/01/27 04:21:14, Michael Krebs wrote: > This fixes a unittest that failed when building ...

12 years, 10 months ago #2

Ben Chan

On 2012/01/27 05:09:11, Ben Chan wrote: > On 2012/01/27 04:21:14, Michael Krebs wrote: > > ...

12 years, 10 months ago #3

Ben Chan

12 years, 7 months ago #4

On 2012/01/27 05:24:49, Ben Chan wrote:
> On 2012/01/27 05:09:11, Ben Chan wrote:
> > On 2012/01/27 04:21:14, Michael Krebs wrote:
> > > This fixes a unittest that failed when building for Chrome OS.  Assuming
> this
> > > change is okay could someone submit this, as I'm not a submitter?
> > 

Please close this issue.
> > LGTM.
> 
> Mike, I committed the CL for you (@r908).

Expand All Messages | Collapse All Messages