Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 345001: Fix test addresses to use uintptr_t instead of u_int64_t. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by Michael Krebs
Modified:
12 years, 5 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix test addresses to use uintptr_t instead of u_int64_t.

When a variable is used to set (and lookup) MappingInfo's "start_addr"
field, it needs to match types -- which is "uintptr_t".  When Chrome OS
updated the 'make' that's used for building, the 32-bit "char *" had
sign-extended when cast up to a u_int64_t -- maybe because pointers were
unsigned before and then changed to be signed -- and that caused the address
lookup to fail.

BUG=chromium-os:25355
TEST=Ran Breakpad unittests

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/handler/exception_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/client/linux/minidump_writer/minidump_writer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Michael Krebs
This fixes a unittest that failed when building for Chrome OS. Assuming this change is ...
12 years, 8 months ago #1
Ben Chan
On 2012/01/27 04:21:14, Michael Krebs wrote: > This fixes a unittest that failed when building ...
12 years, 8 months ago #2
Ben Chan
On 2012/01/27 05:09:11, Ben Chan wrote: > On 2012/01/27 04:21:14, Michael Krebs wrote: > > ...
12 years, 8 months ago #3
Ben Chan
12 years, 5 months ago #4
On 2012/01/27 05:24:49, Ben Chan wrote:
> On 2012/01/27 05:09:11, Ben Chan wrote:
> > On 2012/01/27 04:21:14, Michael Krebs wrote:
> > > This fixes a unittest that failed when building for Chrome OS.  Assuming
> this
> > > change is okay could someone submit this, as I'm not a submitter?
> > 

Please close this issue.
> > LGTM.
> 
> Mike, I committed the CL for you (@r908).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted