Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(700)

Issue 343001: Implement core dump to minidump conversion. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by Ben Chan
Modified:
12 years, 8 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Implement core dump to minidump conversion.

This patch is part of a bigger patch that helps merging the breakpad code
with the modified version in Chromium OS.

Specifically, this patch makes the following changes:
1. Turn the LinuxDumper class into a base class and move ptrace related
   code into a new derived class, LinuxPtraceDumper.
2. Add a LinuxCoreDumper class, which is derived from LinuxDumper, to
   extract information from a crashed process via a core dump file instead
   of ptrace.
3. Add a WriteMinidumpFromCore function to
     src/client/linux/minidump_writer/minidump_writer.h,
   which uses LinuxCoreDumper to extract information from a core dump file.
4. Add a core2md utility, which simply wraps WriteMinidumpFromCore, for
   converting a core dump to a minidump.

BUG=455
TEST=Tested the following:
1. Build on 32-bit and 64-bit Linux with gcc 4.4.3 and gcc 4.6.
2. Build on Mac OS X 10.6.8 with gcc 4.2 and clang 3.0 (with latest gmock).
3. All unit tests pass.
4. Run Chromium OS tests to test core2md.

Patch Set 1 #

Total comments: 10

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 6 chunks +37 lines, -20 lines 0 comments Download
M Makefile.in View 33 chunks +172 lines, -52 lines 0 comments Download
A src/client/linux/minidump_writer/linux_core_dumper.cc View 1 1 chunk +234 lines, -0 lines 0 comments Download
A src/client/linux/minidump_writer/linux_core_dumper.h View 1 chunk +122 lines, -0 lines 0 comments Download
A src/client/linux/minidump_writer/linux_core_dumper_unittest.cc View 1 1 chunk +117 lines, -0 lines 0 comments Download
M src/client/linux/minidump_writer/linux_dumper.cc View 10 chunks +9 lines, -266 lines 0 comments Download
M src/client/linux/minidump_writer/linux_dumper.h View 5 chunks +31 lines, -16 lines 0 comments Download
D src/client/linux/minidump_writer/linux_dumper_unittest.cc View 1 chunk +0 lines, -428 lines 0 comments Download
A src/client/linux/minidump_writer/linux_ptrace_dumper.cc View 1 chunk +292 lines, -0 lines 0 comments Download
A src/client/linux/minidump_writer/linux_ptrace_dumper.h View 1 1 chunk +92 lines, -0 lines 0 comments Download
A src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc View 1 chunk +430 lines, -0 lines 0 comments Download
M src/client/linux/minidump_writer/minidump_writer.cc View 8 chunks +43 lines, -17 lines 0 comments Download
M src/client/linux/minidump_writer/minidump_writer.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/common/linux/elf_core_dump_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/common/linux/tests/crash_generator.cc View 2 chunks +5 lines, -1 line 0 comments Download
M src/common/linux/tests/crash_generator.h View 1 chunk +1 line, -1 line 0 comments Download
A src/tools/linux/core2md/core2md.cc View 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Ben Chan
12 years, 8 months ago #1
kmixter
LGTM to with a few nits and assuming that the functions refactored out of linux_dumper ...
12 years, 8 months ago #2
Ben Chan
Most of the code was copied from linux_dumper.cc to linux_ptrace_dumper.cc except the changes made to ...
12 years, 8 months ago #3
kmixter
12 years, 8 months ago #4
Still LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted