Issue 341001: Build LinuxLibcSupportTest and make it pass.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 341001: Build LinuxLibcSupportTest and make it pass. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by Lei Zhang (chromium)

Modified:
12 years, 7 months ago

Reviewers:
agl, Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Build LinuxLibcSupportTest and make it pass.

Commited as: http://code.google.com/p/google-breakpad/source/detail?r=903

Patch Set 2 : '' #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	Makefile.am	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Makefile.in	View	1	7 chunks	+22 lines, -0 lines	0 comments	Download
M	src/common/linux/linux_libc_support_unittest.cc	View		1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Lei Zhang (chromium)

None of the Chromium bots run breakpad_unittests, and Breakpad doesn't even build it, so this ...

12 years, 8 months ago #1

Ted Mielczarek

LGTM http://breakpad.appspot.com/341001/diff/1/2 File Makefile.am (right): http://breakpad.appspot.com/341001/diff/1/2#newcode256 Line 256: src/common/linux/linux_libc_support_unittest You could probably just lump this ...

12 years, 8 months ago #2

Lei Zhang (chromium)

12 years, 8 months ago #4

On 2012/01/11 13:13:46, Ted Mielczarek wrote:
> LGTM
> 
> http://breakpad.appspot.com/341001/diff/1/2
> File Makefile.am (right):
> 
> http://breakpad.appspot.com/341001/diff/1/2#newcode256
> Line 256: src/common/linux/linux_libc_support_unittest
> You could probably just lump this into linux_client_unittest for simplicity.
It
> doesn't matter much either way.

Sure thing.

Expand All Messages | Collapse All Messages