Issue 338001: Send crash dumps to Google via HTTPS instead of HTTP, since they might

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by palmer

Modified:
13 years ago

Reviewers:
Mark Mentovai, Lei Zhang (chromium), mochalatte

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src/

Visibility:
Public.

Send crash dumps to Google via HTTPS instead of HTTP, since they might
contain sensitive information.

BUG=none
TEST=crash dumps still arrive

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	client/linux/sender/google_crash_report_sender.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5

Lei Zhang (chromium)

LGTM FWIW, Google Chrome has it set to https in src/chrome/app/breakpad_linux.cc.

13 years ago #2

Lei Zhang (chromium)

13 years ago #5

On 2012/01/11 22:15:33, palmer wrote:
> Can somebody with privileges please commit this? Thanks.

I already did in r899.