Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(403)

Issue 335001: Replace MMappedRange with MinidumpMemoryRange. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by Ben Chan
Modified:
12 years, 11 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Replace MMappedRange with MinidumpMemoryRange.

This patch is part of a bigger patch that helps merging the breakpad code
with the modified version in Chromium OS.

The MemoryRange class was added in r895 (http://breakpad.appspot.com/332001),
which is largely based on MMappedRange but generalized to be used in other
code. However, MemoryRange does not support minidump data structures. This
patch adds a MinidumpMemoryRange class that extends MemoryRange to handle
minidump data structures, which can then replace MMappedRange.

As with MemoryRange, MinidumpMemoryRange is unit tested.

BUG=455
TEST=Tested the following:
1. Build on 32-bit and 64-bit Linux with gcc 4.4.3 and gcc 4.6.
2. Build on Mac OS X 10.6.8 with gcc 4.2 and clang 3.0 (with latest gmock).
3. All unit tests pass.
4. Run minidump-2-core to covnert a minidump file to a core file.

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 1 2 chunks +15 lines, -1 line 0 comments Download
M Makefile.in View 1 14 chunks +109 lines, -2 lines 0 comments Download
M src/common/memory_range.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/tools/linux/md2core/minidump-2-core.cc View 1 27 chunks +52 lines, -114 lines 0 comments Download
A src/tools/linux/md2core/minidump_memory_range.h View 1 chunk +89 lines, -0 lines 0 comments Download
A src/tools/linux/md2core/minidump_memory_range_unittest.cc View 1 chunk +258 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Ben Chan
12 years, 11 months ago #1
Ben Chan
http://breakpad.appspot.com/335001/diff/1/5 File src/tools/linux/md2core/minidump-2-core.cc (right): http://breakpad.appspot.com/335001/diff/1/5#newcode388 Line 388: if (!strstr(full_file.GetAsciiMDString(sysinfo->csd_version_rva).c_str(), I renamed GetString to GetAsciiMDString to ...
12 years, 11 months ago #2
Ben Chan
12 years, 11 months ago #3
Ben Chan
Rebased to ToT.
12 years, 11 months ago #4
Michael Krebs
12 years, 11 months ago #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted