Issue 331001: Add API on iOS to generate dump on demand.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 331001: Add API on iOS to generate dump on demand. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by qsr

Modified:
12 years, 11 months ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Add API on iOS to generate dump on demand.

Patch Set 2 : '' #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/client/ios/Breakpad.h	View		2 chunks	+11 lines, -0 lines	0 comments	Download
	M	src/client/ios/Breakpad.mm	View	1	5 chunks	+55 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Mark Mentovai

LGTM http://breakpad.appspot.com/331001/diff/1/3 File src/client/ios/Breakpad.mm (right): http://breakpad.appspot.com/331001/diff/1/3#newcode476 Line 476: dumpId.c_str()); This would all fit on one ...

12 years, 11 months ago #2

qsr

12 years, 11 months ago #3

http://breakpad.appspot.com/331001/diff/1/3
File src/client/ios/Breakpad.mm (right):

http://breakpad.appspot.com/331001/diff/1/3#newcode476
Line 476: dumpId.c_str());
On 2011/12/08 17:56:50, Mark Mentovai wrote:
> This would all fit on one line.

Done.

Expand All Messages | Collapse All Messages