Issue 33002: TBD - Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 33002: TBD (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by mochalatte

Modified:
14 years, 11 months ago

Reviewers:
jimb

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Add support for DWARF end line sequence tag (DW_LNE_end_sequence) #

Patch Set 3 : Add support for DWARF end line sequence tag (DW_LNE_end_sequence) #

Patch Set 4 : Support for DW_LNE_end_sequence + a better DIE handler #

Total comments: 1

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/common/dwarf/dwarf2enums.h	View	1 chunk	+35 lines, -0 lines	0 comments	Download
M	src/common/dwarf/dwarf2reader.cc	View	1 chunk	+11 lines, -9 lines	0 comments	Download
M	src/common/dwarf/dwarf2reader.h	View	1 chunk	+10 lines, -0 lines	1 comment	Download
M	src/common/dwarf/functioninfo.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/common/dwarf/functioninfo.h	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/tools/linux/dump_syms/Makefile	View	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

jimb

15 years, 2 months ago #1

http://breakpad.appspot.com/33002/diff/1008/1011
File src/common/dwarf/dwarf2reader.h (right):

http://breakpad.appspot.com/33002/diff/1008/1011#newcode185
Line 185: virtual void EndSequence(uint64 address) { }
For what it's worth, Daniel Berlin and I discussed this change to the DWARF
reader interface, and decided to instead add a "length" parameter to AddLine. 
Thread:
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/ed8d2...

Expand All Messages | Collapse All Messages