Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(21)

Issue 329001: Create a static library to use Breakpad on iOS. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by qsr
Modified:
12 years, 11 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

 Create a static library to use Breakpad on iOS.

 This obliged me to move BreakpadDefines.h to
src/client/apple/Framework/BreakpadDefines.h

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
A + src/client/apple/Framework/BreakpadDefines.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A src/client/ios/Breakpad.xcodeproj/project.pbxproj View 1 chunk +529 lines, -0 lines 0 comments Download
A src/client/ios/Breakpad_Prefix.pch View 1 chunk +7 lines, -0 lines 0 comments Download
M src/client/mac/Breakpad.xcodeproj/project.pbxproj View 7 chunks +22 lines, -4 lines 0 comments Download
M src/client/mac/Framework/Breakpad.mm View 1 chunk +1 line, -1 line 0 comments Download
D src/client/mac/Framework/BreakpadDefines.h View 1 chunk +0 lines, -72 lines 0 comments Download
M src/client/mac/crash_generation/ConfigFile.mm View 1 chunk +1 line, -1 line 0 comments Download
M src/client/mac/sender/crash_report_sender.m View 1 chunk +1 line, -1 line 0 comments Download
M src/client/mac/sender/uploader.mm View 1 chunk +1 line, -1 line 0 comments Download
M src/tools/mac/dump_syms/dump_syms.xcodeproj/project.pbxproj View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2
qsr
12 years, 11 months ago #1
Mark Mentovai
12 years, 11 months ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted