Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7597)

Issue 322003: Rename md5.c to md5.cc and put it in a namespace (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by Ted Mielczarek
Modified:
12 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

On our WebRTC project branch, we hit a linker error because we're linking in
libjingle, which has this same md5.c. This patch just makes md5.c into md5.cc,
and sticks the whole thing into the google_breakpad namespace.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 2 chunks +2 lines, -2 lines 0 comments Download
M Makefile.in View 3 chunks +3 lines, -3 lines 0 comments Download
M src/client/mac/Breakpad.xcodeproj/project.pbxproj View 9 chunks +12 lines, -13 lines 0 comments Download
M src/client/mac/handler/minidump_test.xcodeproj/project.pbxproj View 4 chunks +4 lines, -4 lines 0 comments Download
M src/client/solaris/handler/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/common/mac/macho_id.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/common/mac/macho_id.h View 1 chunk +1 line, -1 line 0 comments Download
M src/common/md5.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/common/md5.h View 1 chunk +3 lines, -7 lines 0 comments Download
M src/tools/mac/crash_report/crash_report.xcodeproj/project.pbxproj View 6 chunks +5 lines, -5 lines 0 comments Download
M src/tools/mac/dump_syms/dump_syms.xcodeproj/project.pbxproj View 5 chunks +4 lines, -5 lines 0 comments Download
M src/tools/solaris/dump_syms/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Ted Mielczarek
12 years, 10 months ago #1
Mark Mentovai
12 years, 10 months ago #2
Sounds fine. LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted