Issue 320001: Merge trunk r875 to the chrome_15 branch

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 320001: Merge trunk r875 to the chrome_15 branch (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by Mark Mentovai

Modified:
11 years ago

Reviewers:
Lei Zhang (chromium)

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/branches/chrome_15/

Visibility:
Public.

Description

Merge trunk r875 to the chrome_15 branch.

Fix some shadow variables, including one in file_id.cc that causes all files to
generate the same hash. Add a test to make sure this doesn't happen again.

Review URL: http://breakpad.appspot.com/316002

Original patch by Lei Zhang <thestig@chromium.org>

Patch Set 1 #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/client/linux/minidump_writer/minidump_writer.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/common/linux/file_id.cc	View	5 chunks	+7 lines, -11 lines	0 comments	Download
M	src/common/linux/file_id_unittest.cc	View	2 chunks	+101 lines, -0 lines	0 comments	Download
M	src/common/stabs_reader.cc	View	5 chunks	+6 lines, -6 lines	0 comments	Download
M	src/processor/source_line_resolver_base.cc	View	4 chunks	+7 lines, -7 lines	0 comments	Download
M	src/tools/linux/md2core/minidump-2-core.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lgtm

Expand All Messages | Collapse All Messages