Allow to retrieve id of a module from memory instead of going to disk for iOS.

Allow to retrieve id of a module from memory instead of going to disk for iOS.

 Allow macho_id and macho_walker to read data from memory.
 Wire up this when reading module on iOS.

[Mark Mentovai]

http://breakpad.appspot.com/319001/diff/1/2
File src/client/mac/handler/minidump_generator.cc (right):

http://breakpad.appspot.com/319001/diff/1/2#newcode1253
Line 1253: //  in_memory = false;
Remove this, it looks like something left over from testing.

http://breakpad.appspot.com/319001/diff/1/2#newcode1282
Line 1282: MacFileUtilities::MachoID macho(module_path, (void
*)module->base_of_image,
Use C++<style>(casts) and not (C-style)casts.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Castin...

http://breakpad.appspot.com/319001/diff/1/4
File src/common/mac/macho_id.cc (right):

http://breakpad.appspot.com/319001/diff/1/4#newcode238
Line 238: else {
Use the “cuddly else”, } else {, on one line.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Condit...

http://breakpad.appspot.com/319001/diff/1/6
File src/common/mac/macho_walker.cc (right):

http://breakpad.appspot.com/319001/diff/1/6#newcode115
Line 115: memcpy(buffer, (char *)memory_ + offset, size);
C++-style casts.

http://breakpad.appspot.com/319001/diff/1/7
File src/common/mac/macho_walker.h (right):

http://breakpad.appspot.com/319001/diff/1/7#newcode90
Line 90: // Memory location to read from.
Blank line before.

http://breakpad.appspot.com/319001/diff/1/7#newcode92
Line 92: // Size of the memory segment we can read from.
Blank line before. These help the eye see each of these members as distinct
entities.

[qsr]

PTAL

http://breakpad.appspot.com/319001/diff/1/2
File src/client/mac/handler/minidump_generator.cc (right):

http://breakpad.appspot.com/319001/diff/1/2#newcode1253
Line 1253: //  in_memory = false;
On 2011/10/20 13:45:51, Mark Mentovai wrote:
> Remove this, it looks like something left over from testing.

Done. Sorry I was sure I add uploaded the second version.

http://breakpad.appspot.com/319001/diff/1/2#newcode1282
Line 1282: MacFileUtilities::MachoID macho(module_path, (void
*)module->base_of_image,
On 2011/10/20 13:45:51, Mark Mentovai wrote:
> Use C++<style>(casts) and not (C-style)casts.
> 
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Castin...

Done.

http://breakpad.appspot.com/319001/diff/1/4
File src/common/mac/macho_id.cc (right):

http://breakpad.appspot.com/319001/diff/1/4#newcode238
Line 238: else {
On 2011/10/20 13:45:51, Mark Mentovai wrote:
> Use the “cuddly else”, } else {, on one line.
> 
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Condit...

Done.

http://breakpad.appspot.com/319001/diff/1/6
File src/common/mac/macho_walker.cc (right):

http://breakpad.appspot.com/319001/diff/1/6#newcode115
Line 115: memcpy(buffer, (char *)memory_ + offset, size);
On 2011/10/20 13:45:51, Mark Mentovai wrote:
> C++-style casts.

Done.

http://breakpad.appspot.com/319001/diff/1/7
File src/common/mac/macho_walker.h (right):

http://breakpad.appspot.com/319001/diff/1/7#newcode90
Line 90: // Memory location to read from.
On 2011/10/20 13:45:51, Mark Mentovai wrote:
> Blank line before.

Done.

http://breakpad.appspot.com/319001/diff/1/7#newcode92
Line 92: // Size of the memory segment we can read from.
On 2011/10/20 13:45:51, Mark Mentovai wrote:
> Blank line before. These help the eye see each of these members as distinct
> entities.

Done.

[Mark Mentovai]

LG otherwise.

http://breakpad.appspot.com/319001/diff/3004/4005
File src/common/mac/macho_walker.cc (right):

http://breakpad.appspot.com/319001/diff/3004/4005#newcode113
Line 113: if (size < 0)
I think this is ineffective, because size is a size_t, which is unsigned. You
can probably just get rid of this. I’m surprised the compiler didn’t complain. I
guess this warning is only enabled with -Wextra with GCC. Clang warns about it
more readily.