Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(52)

Issue 313002: Fix harmless printf abuse in symupload (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by Mark Mentovai
Modified:
13 years, 1 month ago
Reviewers:
qsr
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix harmless printf abuse in symupload.

symupload printed -[NSData length], an NSUInteger, using %lu. %lu is proper
to print a "long" as unsigned, but NSUInteger is a typedef for "unsigned int"
when building for 32-bit. This would not have caused any problems, because in
the 32-bit model, both int and long are 32 bits wide. In the 64-bit model,
long is 64 bits wide, but NSUInteger is defiend as "unsigned long", so there
wouldn't have even been a warning in that case.

This addresses the following warning:

symupload.m:137:30:{137:28-137:31}{137:46-137:59}: warning: conversion specifies
type 'unsigned long' but the argument has type 'NSUInteger' (aka 'unsigned int')
[-Wformat]

Committed r860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/tools/mac/symupload/symupload.m View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2
Mark Mentovai
13 years, 1 month ago #1
qsr
13 years, 1 month ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted