Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25)

Issue 312002: Remove "using namespace std" from dwarf2reader.h (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by Mark Mentovai
Modified:
13 years, 1 month ago
Reviewers:
qsr, jimb
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Remove "using namespace std" from dwarf2reader.h. Using-directives are
forbidden by the style guide, and are bad practice in headers even under
style rules that tolerate this construct.

This fixes warnings such as:

In file included from dwarf2reader.cc:34:
dwarf2reader.h:53:17: warning: using namespace directive in global context in
header [-Wheader-hygiene]

Committed r862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/dwarf/dwarf2diehandler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/common/dwarf/dwarf2diehandler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/common/dwarf/dwarf2reader.cc View 13 chunks +15 lines, -14 lines 0 comments Download
M src/common/dwarf/dwarf2reader.h View 13 chunks +17 lines, -18 lines 0 comments Download
M src/common/dwarf_line_to_module.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 3
Mark Mentovai
13 years, 1 month ago #1
Mark Mentovai
(TBR)
13 years, 1 month ago #2
jimb
13 years, 1 month ago #3
LGTM

I don't like 'using namespace' much either; I don't know what I was thinking
when I added that, or approved its addition.

I would kind of rather see 'using std::string' than meaningless "std::" prefixes
all over, but that's fine.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted