Extract constants from Breakpad.h.

Extract constants from Breakpad.h.

 This is done to allow ios implementation to use the same constants.

[Mark Mentovai]

http://breakpad.appspot.com/311001/diff/3010/4004
File src/client/mac/Framework/BreakpadDefines.h (right):

http://breakpad.appspot.com/311001/diff/3010/4004#newcode76
Line 76: #define BREAKPAD_BOOTSTRAP_PARENT_PORT   
"com.Breakpad.BootstrapParent"
Put this back where you found it. Unless you know you need it here, of course.

It’s a different sort of constant that’s only used for the partial
out-of-process dump support that isn’t compatible with the iOS mode. I doubt
you’ll need it.

[qsr]

http://breakpad.appspot.com/311001/diff/3010/4004
File src/client/mac/Framework/BreakpadDefines.h (right):

http://breakpad.appspot.com/311001/diff/3010/4004#newcode76
Line 76: #define BREAKPAD_BOOTSTRAP_PARENT_PORT   
"com.Breakpad.BootstrapParent"
On 2011/10/11 14:14:32, Mark Mentovai wrote:
> Put this back where you found it. Unless you know you need it here, of course.
> 
> It’s a different sort of constant that’s only used for the partial
> out-of-process dump support that isn’t compatible with the iOS mode. I doubt
> you’ll need it.

 You are perfectly right, tjat I won't need it, but I was thinking that having
all the constants in the same place was better. If you prefer to have this one
on Breakpad.h, I'll put it back there.

[qsr]

PTAL

[Mark Mentovai]

LGTM

http://breakpad.appspot.com/311001/diff/5002/6003
File src/client/mac/Framework/Breakpad.h (right):

http://breakpad.appspot.com/311001/diff/5002/6003#newcode46
Line 46: #define BREAKPAD_BOOTSTRAP_PARENT_PORT   
"com.Breakpad.BootstrapParent"
My only thought here is that if this doesn’t make sense on iOS, not defining it
in a header that might be included on iOS keeps you from accidentally building
code that actually does try to use this on that platform.