Issue 31001: Added ability for crash_report to run through a directory

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 31001: Added ability for crash_report to run through a directory

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by krisr

Modified:
15 years, 1 month ago

Reviewers:
mochalatte

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Fixing whitespace #

Patch Set 3 : More whitespace fixes #

Patch Set 4 : fixing while loop #

Patch Set 5 : adding neal as a reviewer #

Total comments: 1

Patch Set 6 : adding nealsid's suggestions #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/tools/mac/crash_report/crash_report.mm	View	1 2 3 4 5	2 chunks	+28 lines, -5 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

mochalatte

15 years, 1 month ago #1

LGTM, Kris
Thanks for the patch.

Neal

http://breakpad.appspot.com/31001/diff/1006/8
File src/tools/mac/crash_report/crash_report.mm (right):

http://breakpad.appspot.com/31001/diff/1006/8#newcode316
Line 316: && is_dir) {
i would just make this:

BOOL file_exists = [manager fileExistsAtPath:minidump_path isDirectory:is_dir];
if (file_exists && is_dir) { ...
...
} else if (file_exists) {
...

}
That way we're not potentially calling ProcessSingleReport on a nonexistant
file.(and it also gets away from a style of setting a variable and testing it in
the same boolean expression, which works but I'm not a fan of because it's
slightly harder to follow)

Expand All Messages | Collapse All Messages