Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 310003: Fix harmless warning in dwarf_cfi_to_module.cc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 12 months ago by Mark Mentovai
Modified:
12 years, 12 months ago
Reviewers:
qsr
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix harmless warning in dwarf_cfi_to_module.cc.

This function already establishes that (signed) i must be positive by the time
it assigns it to (unsigned) reg. Because reg is unsigned, it is impossible for
it to be negative. Because i was already checked for positivity, this check
can be removed entirely. It was not a miswritten check that intended to check
i instead of reg, because i is already checked.

This addresses the following warning:

dwarf_cfi_to_module.cc:135:9: warning: comparison of 0 <= unsigned expression is
always true [-Wtautological-compare]

Committed r861

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/dwarf_cfi_to_module.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Mark Mentovai
12 years, 12 months ago #1
qsr
12 years, 12 months ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted