Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(18)

Issue 309003: Breakpad implementation for ios. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by qsr
Modified:
13 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

 Breakpad implementation for ios.

 To be noted:
 1) All is done in process, as multi-process is not allowed on ios.
 2) Dump are saved when a crash occures but are not automatically send to the
    server.
 3) Breakpad.h contains function to check if a dump must be uploaded, and to
    upload a dump.
 4) The code is copy pasting a log of Breakpad implementation for Mac OS. It
    might be possible to do some refactoring.

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 5

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
A src/client/ios/Breakpad.h View 1 2 1 chunk +201 lines, -0 lines 0 comments Download
A src/client/ios/Breakpad.mm View 1 2 1 chunk +683 lines, -0 lines 0 comments Download
M src/client/mac/sender/uploader.m View 1 2 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2
qsr
13 years, 1 month ago #1
Mark Mentovai
13 years, 1 month ago #2
LGTM mostly as a rubber-stamp.

I would prefer sharing code but the refactoring to get the #ifdefs to not be
terrible might be a bigger project than you want to take on.

http://breakpad.appspot.com/309003/diff/2001/3001
File src/client/ios/Breakpad.h (right):

http://breakpad.appspot.com/309003/diff/2001/3001#newcode29
Line 29: //
This line should be blank (no //) so that it doesn’t look like it’s part of the
ugly license block.

http://breakpad.appspot.com/309003/diff/2001/3001#newcode50
Line 50: // Optional user-defined function to dec to decide if we should handle
Remove “dec to”

http://breakpad.appspot.com/309003/diff/2001/3002
File src/client/ios/Breakpad.mm (right):

http://breakpad.appspot.com/309003/diff/2001/3002#newcode29
Line 29: //
Remove.

http://breakpad.appspot.com/309003/diff/2001/3002#newcode684
Line 684: }
I’m not actually going to reread the entire implementation of this file.

http://breakpad.appspot.com/309003/diff/2001/3003
File src/client/mac/sender/uploader.m (right):

http://breakpad.appspot.com/309003/diff/2001/3003#newcode34
Line 34: #include <TargetConditionals.h>
Sort (case-insensitively).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted