Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(22)

Issue 309002: Extract the uploader process from crash_report_sender (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by qsr
Modified:
13 years ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

 Extract the uploader process from crash_report_sender

 The aim is to separate the process itself from the view, to be able to
reuse the process on the iOS platform.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/mac/Breakpad.xcodeproj/project.pbxproj View 4 chunks +6 lines, -0 lines 0 comments Download
M src/client/mac/sender/crash_report_sender.h View 1 2 3 2 chunks +2 lines, -25 lines 0 comments Download
M src/client/mac/sender/crash_report_sender.m View 1 2 3 11 chunks +34 lines, -545 lines 0 comments Download
A src/client/mac/sender/uploader.h View 1 2 3 1 chunk +74 lines, -0 lines 0 comments Download
A src/client/mac/sender/uploader.m View 1 2 3 4 5 1 chunk +579 lines, -0 lines 0 comments Download

Messages

Total messages: 2
qsr
13 years ago #1
Mark Mentovai
13 years ago #2
LGTM (refactoring rubber-stamp)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted