Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 309001: Extracting the config file class from the Inspector to be able to reuse it. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 12 months ago by qsr
Modified:
12 years, 12 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

 Extracting the config file class from the Inspector to be able to reuse it.

 This will be needed for iOS implementation, where the Inspector won't be
used, but where a config file will still be needed, because the uploads
won't happen just after the crash, but on a next run.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 7

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/mac/Breakpad.xcodeproj/project.pbxproj View 6 chunks +10 lines, -0 lines 0 comments Download
A src/client/mac/crash_generation/ConfigFile.h View 1 2 3 1 chunk +83 lines, -0 lines 0 comments Download
A src/client/mac/crash_generation/ConfigFile.mm View 1 2 3 1 chunk +229 lines, -0 lines 0 comments Download
M src/client/mac/crash_generation/Inspector.h View 1 2 3 3 chunks +1 line, -46 lines 0 comments Download
M src/client/mac/crash_generation/Inspector.mm View 5 chunks +2 lines, -178 lines 0 comments Download
M src/common/mac/SimpleStringDictionary.h View 1 chunk +1 line, -1 line 0 comments Download
M src/common/mac/SimpleStringDictionary.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
qsr
12 years, 12 months ago #1
Mark Mentovai
12 years, 12 months ago #2
LGTM

http://breakpad.appspot.com/309001/diff/4001/5002
File src/client/mac/crash_generation/ConfigFile.h (right):

http://breakpad.appspot.com/309001/diff/4001/5002#newcode1
Line 1: // Copyright (c) 2007, Google Inc.
2011

http://breakpad.appspot.com/309001/diff/4001/5002#newcode32
Line 32: #import "common/mac/SimpleStringDictionary.h"
Use standard sort order. The system headers come before non-system headers.

http://breakpad.appspot.com/309001/diff/4001/5002#newcode36
Line 36: #define VERBOSE 0
VERBOSE, gDebugLog, and DEBUGLOG don’t seem to be used in this header and thus
don’t really belong here.

http://breakpad.appspot.com/309001/diff/4001/5003
File src/client/mac/crash_generation/ConfigFile.mm (right):

http://breakpad.appspot.com/309001/diff/4001/5003#newcode1
Line 1: // Copyright (c) 2007, Google Inc.
2011

http://breakpad.appspot.com/309001/diff/4001/5003#newcode41
Line 41: #import <Foundation/Foundation.h>
This is a system header and belongs up with the <stdio.h> group.

http://breakpad.appspot.com/309001/diff/4001/5003#newcode57
Line 57: dirPath = [[mgr currentDirectoryPath]
stringByAppendingPathComponent:dirPath];
80 characters.

http://breakpad.appspot.com/309001/diff/4001/5003#newcode226
Line 226: 
Unnecessary blank line at EOF.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted