Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1004)

Issue 306001: Use a bootstrap subset port for the inspector (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by Mark Mentovai
Modified:
13 years, 1 month ago
Reviewers:
mochalatte
CC:
google-breakpad-dev_googlegroups.com, avi_chromium.org
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Use a bootstrap subset port for the inspector, tying the subset to the
lifetime of the task to be monitored, the invoking task. This allows the
bootstrap server (in launchd) to automatically clean up the Mach server
registration when the task being monitored exits, avoiding leaks of
com.Breakpad.Inspector(pid) ports in "launchctl bslist".

BUG=chromium:28547
TEST=Handler should still crash catches, but inspector ports should no longer
     show up in "launchctl bslist". They should show up under a subset port in
     "launchctl bstree" instead. "launchctl bstree" must be invoked as root.

Committed r842.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/mac/Framework/OnDemandServer.mm View 3 chunks +26 lines, -10 lines 0 comments Download

Messages

Total messages: 2
Mark Mentovai
TBR. Committed Breakpad r842.
13 years, 1 month ago #1
mochalatte
13 years, 1 month ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted