Issue 304001: Linux/Mac: Add option to omit the CFI section in dump_syms.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 304001: Linux/Mac: Add option to omit the CFI section in dump_syms. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by Lei Zhang (chromium)

Modified:
13 years, 2 months ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Linux/Mac: Add option to omit the CFI section in dump_syms.

Committed as r835.

Patch Set 2 : '' #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	src/common/linux/dump_symbols.cc	View		5 chunks	+5 lines, -3 lines	0 comments	Download
M	src/common/linux/dump_symbols.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	src/common/linux/dump_symbols_unittest.cc	View		7 chunks	+15 lines, -11 lines	0 comments	Download
M	src/common/mac/dump_syms.h	View		6 chunks	+12 lines, -12 lines	0 comments	Download
M	src/common/mac/dump_syms.mm	View		14 chunks	+24 lines, -24 lines	0 comments	Download
M	src/common/module.cc	View		13 chunks	+46 lines, -40 lines	0 comments	Download
M	src/common/module.h	View		3 chunks	+7 lines, -6 lines	0 comments	Download
M	src/common/module_unittest.cc	View		12 chunks	+57 lines, -11 lines	0 comments	Download
M	src/tools/linux/dump_syms/dump_syms.cc	View	1	2 chunks	+31 lines, -11 lines	0 comments	Download
M	src/tools/mac/dump_syms/dump_syms_tool.mm	View		7 chunks	+13 lines, -8 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Mark Mentovai

This is more plumbing than I expected. http://breakpad.appspot.com/304001/diff/1/10 File src/tools/linux/dump_syms/dump_syms.cc (right): http://breakpad.appspot.com/304001/diff/1/10#newcode44 Line 44: fprintf(stderr, ...

13 years, 2 months ago #2

Lei Zhang (chromium)

http://breakpad.appspot.com/304001/diff/1/10 File src/tools/linux/dump_syms/dump_syms.cc (right): http://breakpad.appspot.com/304001/diff/1/10#newcode44 Line 44: fprintf(stderr, " --no-cfi Do not generate CFI section\n"); ...

13 years, 2 months ago #3

LGTM

Expand All Messages | Collapse All Messages