Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 302001: Adjust MD_CONTEXT_CPU_MASK to reflect reality (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by Ted Mielczarek
Modified:
13 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

The value of MD_CONTEXT_CPU_MASK in use assumes that only the lower 6 bits are
used for flags, and the upper 26 bits are for the CPU type. However, as of
Windows 7 SP1, the 7th bit is being used as a flag (per
http://msdn.microsoft.com/en-us/library/hh134238%28v=vs.85%29.aspx and the
Windows SDK headers). Adjusting MD_CONTEXT_CPU_MASK works, but unfortunately
that masks off the existing value of MD_CONTEXT_ARM. This patch also changes the
value of MD_CONTEXT_ARM and adjusts the minidump context reading machinery to
gracefully handle minidumps with the old value.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/google_breakpad/common/minidump_cpu_amd64.h View 1 chunk +6 lines, -2 lines 0 comments Download
M src/google_breakpad/common/minidump_cpu_arm.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/google_breakpad/common/minidump_cpu_x86.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/google_breakpad/common/minidump_format.h View 1 chunk +5 lines, -4 lines 0 comments Download
M src/processor/minidump.cc View 1 chunk +10 lines, -0 lines 1 comment Download
M src/processor/minidump_unittest.cc View 2 chunks +316 lines, -0 lines 0 comments Download
M src/processor/synth_minidump.cc View 2 chunks +41 lines, -1 line 0 comments Download
M src/processor/synth_minidump.h View 3 chunks +12 lines, -1 line 0 comments Download
M src/processor/synth_minidump_unittest.cc View 3 chunks +55 lines, -0 lines 0 comments Download
M src/processor/synth_minidump_unittest_data.h View 3 chunks +198 lines, -32 lines 0 comments Download

Messages

Total messages: 2
Ted Mielczarek
Forgot to check "send mail" as usual...
13 years, 2 months ago #1
Mark Mentovai
13 years, 2 months ago #2
LGTM

http://breakpad.appspot.com/302001/diff/1/6
File src/processor/minidump.cc (right):

http://breakpad.appspot.com/302001/diff/1/6#newcode419
Line 419: context_flags |= MD_CONTEXT_ARM;
And unset MD_CONTEXT_ARM_OLD?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted