Issue 298002: Fix clang warnings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 298002: Fix clang warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by Mark Mentovai

Modified:
12 years, 11 months ago

Reviewers:
Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Fix clang warnings.

Landed r823

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/client/mac/crash_generation/Inspector.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/client/mac/crash_generation/Inspector.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/client/mac/handler/minidump_generator.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/common/mac/MachIPC.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 3

Mark Mentovai

clang warned about this stuff. There are also some deprecation warnings that I’m ignoring at ...

12 years, 11 months ago #1

Ted Mielczarek

LGTM. There are a couple of clang c++0x correctness fixes from Rafael sitting in my ...

12 years, 11 months ago #2

Thanks, I committed both of Rafael’s patches too.