Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(132)

Issue 298001: Zero out the entire context on MD5_Final, not just the number of bytes in a pointer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by Mark Mentovai
Modified:
13 years, 1 month ago
Reviewers:
Ted Mielczarek
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Zero out the entire context on MD5_Final, not just the number of bytes in a
pointer.

Landed r822

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/md5.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Mark Mentovai
13 years, 1 month ago #1
Ted Mielczarek
13 years, 1 month ago #2
LGTM. Sure wish C++ didn't make it so easy to make this mistake!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted