Issue 294001: Switch mac WriteSymbolFile to use an ostream

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 294001: Switch mac WriteSymbolFile to use an ostream (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by Ted Mielczarek

Modified:
13 years, 1 month ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

Description

In rev 794 I switched the Module::Write method to use an ostream for output
instead of a FILE*, for ease of unit testing. I forgot that the mac dumper code
uses Module as well, so I broke the mac build with that. This patch switches the
mac DumpSymbols::WriteSymbolFile function to use an ostream as well, which
seemed like the simplest fix

Patch Set 1 #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/common/mac/dump_syms.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/common/mac/dump_syms.mm	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/tools/mac/dump_syms/dump_syms_tool.mm	View	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM.

Expand All Messages | Collapse All Messages