Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(61)

Issue 292001: Remove NetworkSourceLine{Resolver,Server} and related code (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by Ted Mielczarek
Modified:
12 years, 9 months ago
Reviewers:
Jess
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

The NetworkSourceLine{Resolver,Server} code was a design I wanted to use in our
production processing, but it never wound up being useful enough to get thre,
and it added too much complexity to be worthwhile. We should just remove all
this code to get rid of the maintenence burden.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 7 chunks +2 lines, -105 lines 0 comments Download
M Makefile.in View 30 chunks +5 lines, -424 lines 0 comments Download
M configure View 2 chunks +0 lines, -71 lines 0 comments Download
M configure.ac View 1 chunk +0 lines, -9 lines 0 comments Download
M src/config.h.in View 1 chunk +0 lines, -3 lines 0 comments Download
R src/google_breakpad/processor/network_source_line_resolver.h View 1 chunk +0 lines, -187 lines 0 comments Download
R src/processor/network_interface.h View 1 chunk +0 lines, -62 lines 0 comments Download
R src/processor/network_source_line_protocol.h View 1 chunk +0 lines, -162 lines 0 comments Download
R src/processor/network_source_line_resolver.cc View 1 chunk +0 lines, -455 lines 0 comments Download
R src/processor/network_source_line_resolver_server_unittest.cc View 1 chunk +0 lines, -195 lines 0 comments Download
R src/processor/network_source_line_resolver_unittest.cc View 1 chunk +0 lines, -535 lines 0 comments Download
R src/processor/network_source_line_server.cc View 1 chunk +0 lines, -435 lines 0 comments Download
R src/processor/network_source_line_server.h View 1 chunk +0 lines, -136 lines 0 comments Download
R src/processor/network_source_line_server_unittest.cc View 1 chunk +0 lines, -963 lines 0 comments Download
R src/processor/source_daemon.cc View 1 chunk +0 lines, -127 lines 0 comments Download
R src/processor/udp_network.cc View 1 chunk +0 lines, -187 lines 0 comments Download
R src/processor/udp_network.h View 1 chunk +0 lines, -73 lines 0 comments Download

Messages

Total messages: 2
Ted Mielczarek
12 years, 9 months ago #1
Jess
12 years, 9 months ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted