Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(165)

Issue 29004: New uploader for linux with makefile changes to generate library + command line util. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 2 months ago by mochalatte
Modified:
15 years, 1 month ago
Reviewers:
cmasone
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Removed extra files #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M client/linux/Makefile View 2 chunks +57 lines, -9 lines 0 comments Download
M client/linux/handler/exception_handler.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A client/linux/sender/google_crash_report_sender.cc View 1 chunk +102 lines, -0 lines 0 comments Download
A common/linux/google_crashdump_uploader.cc View 1 chunk +196 lines, -0 lines 0 comments Download
A common/linux/google_crashdump_uploader.h View 1 chunk +98 lines, -0 lines 0 comments Download
A common/linux/google_crashdump_uploader_test.cc View 1 chunk +166 lines, -0 lines 0 comments Download
A common/linux/libcurl_wrapper.cc View 1 chunk +209 lines, -0 lines 0 comments Download
A common/linux/libcurl_wrapper.h View 1 chunk +82 lines, -0 lines 0 comments Download
A third_party/linux/include/gflags/gflags.h View 1 chunk +533 lines, -0 lines 0 comments Download
A third_party/linux/include/gflags/gflags_completions.h View 1 chunk +121 lines, -0 lines 0 comments Download
A third_party/linux/include/glog/log_severity.h View 1 chunk +84 lines, -0 lines 0 comments Download
A third_party/linux/include/glog/logging.h View 1 chunk +1499 lines, -0 lines 0 comments Download
A third_party/linux/include/glog/raw_logging.h View 1 chunk +185 lines, -0 lines 0 comments Download
A third_party/linux/include/glog/stl_logging.h View 1 chunk +154 lines, -0 lines 0 comments Download
A third_party/linux/include/glog/vlog_is_on.h View 1 chunk +128 lines, -0 lines 0 comments Download
A third_party/linux/lib/gflags/libgflags.a View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/linux/lib/glog/libglog.a View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2
mochalatte
Hi Chris Here's a new uploader with unit tests. Nothing in third_party needs to be ...
15 years, 2 months ago #1
cmasone
15 years, 2 months ago #2
Assuming that breakpad isn't required to follow the 80-char guideline like other
google-created projects, LGTM :-)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted