Issue 29004: New uploader for linux with makefile changes to generate library + command line util.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 29004: New uploader for linux with makefile changes to generate library + command line util. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by mochalatte

Modified:
14 years, 6 months ago

Reviewers:
cmasone

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Removed extra files #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	client/linux/Makefile	View	2 chunks	+57 lines, -9 lines	0 comments	Download
M	client/linux/handler/exception_handler.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A	client/linux/sender/google_crash_report_sender.cc	View	1 chunk	+102 lines, -0 lines	0 comments	Download
A	common/linux/google_crashdump_uploader.cc	View	1 chunk	+196 lines, -0 lines	0 comments	Download
A	common/linux/google_crashdump_uploader.h	View	1 chunk	+98 lines, -0 lines	0 comments	Download
A	common/linux/google_crashdump_uploader_test.cc	View	1 chunk	+166 lines, -0 lines	0 comments	Download
A	common/linux/libcurl_wrapper.cc	View	1 chunk	+209 lines, -0 lines	0 comments	Download
A	common/linux/libcurl_wrapper.h	View	1 chunk	+82 lines, -0 lines	0 comments	Download
A	third_party/linux/include/gflags/gflags.h	View	1 chunk	+533 lines, -0 lines	0 comments	Download
A	third_party/linux/include/gflags/gflags_completions.h	View	1 chunk	+121 lines, -0 lines	0 comments	Download
A	third_party/linux/include/glog/log_severity.h	View	1 chunk	+84 lines, -0 lines	0 comments	Download
A	third_party/linux/include/glog/logging.h	View	1 chunk	+1499 lines, -0 lines	0 comments	Download
A	third_party/linux/include/glog/raw_logging.h	View	1 chunk	+185 lines, -0 lines	0 comments	Download
A	third_party/linux/include/glog/stl_logging.h	View	1 chunk	+154 lines, -0 lines	0 comments	Download
A	third_party/linux/include/glog/vlog_is_on.h	View	1 chunk	+128 lines, -0 lines	0 comments	Download
A	third_party/linux/lib/gflags/libgflags.a	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	third_party/linux/lib/glog/libglog.a	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

mochalatte

Hi Chris Here's a new uploader with unit tests. Nothing in third_party needs to be ...

14 years, 7 months ago #1

cmasone

14 years, 7 months ago #2

Assuming that breakpad isn't required to follow the 80-char guideline like other
google-created projects, LGTM :-)

Expand All Messages | Collapse All Messages