Issue 284001: Fix linux-gate handling in LinuxDumper to get valid File IDs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 284001: Fix linux-gate handling in LinuxDumper to get valid File IDs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by Ted Mielczarek

Modified:
13 years, 6 months ago

Reviewers:
mochalatte

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

Description

The linux-gate handling has been kind of broken in LinuxDumper for a while,
probably since I changed how File IDs were generated. Since it's not a physical
file on disk, the existing File ID generation fails. This patch causes us to
special-case it so we get a valid File ID out of it. I would guess that the
linux-gate symbol files in the tree need to be updated as well, since they will
probably have different IDs, but I only currently have a 64-bit Linux, so I'm
not 100% sure of the process to regenerate them.

Patch Set 1 #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/client/linux/minidump_writer/linux_dumper.cc	View		1 chunk	+15 lines, -0 lines	0 comments	Download
	M	src/client/linux/minidump_writer/linux_dumper_unittest.cc	View		2 chunks	+77 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

mochalatte

13 years, 6 months ago #2

LGTM
Yeah, updating the symbol files should be an easier-to-repeat process.  IIRC
every process on a system will have the same linux-gate mapped but I wonder if
the mapping for the VDSO itself has even changed in recent versions of Linux.

Expand All Messages | Collapse All Messages