Issue 265001: Make programs in src/tools/linux build via the automake build system

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 265001: Make programs in src/tools/linux build via the automake build system (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by Ted Mielczarek

Modified:
13 years, 1 month ago

Reviewers:
jimb

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

Description

I got tired of the fiddly Makefile build for the Linux dump_syms tool, so I went
ahead and autoconfiscated it along with its unit tests, and the other things in
src/tools/linux. There are a few fiddly code changes in here, mostly because I
lumped all the dump_syms unit tests into one binary, and we had a few tests that
used the same test fixture name in different ways. This builds and passes all
tests on my Ubuntu system.

Patch Set 1 #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	Makefile.am	View	4 chunks	+81 lines, -1 line	0 comments	Download
M	Makefile.in	View	21 chunks	+865 lines, -12 lines	0 comments	Download
M	configure	View	8 chunks	+230 lines, -6 lines	0 comments	Download
M	configure.ac	View	2 chunks	+21 lines, -2 lines	0 comments	Download
M	src/common/dwarf_cu_to_module_unittest.cc	View	4 chunks	+16 lines, -16 lines	0 comments	Download
M	src/common/dwarf_line_to_module_unittest.cc	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	src/common/stabs_reader.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/config.h.in	View	1 chunk	+30 lines, -0 lines	0 comments	Download
R	src/tools/linux/dump_syms/Makefile	View	1 chunk	+0 lines, -410 lines	0 comments	Download
R	src/tools/linux/symupload/Makefile	View	1 chunk	+0 lines, -24 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages