Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(104)

Issue 258001: Add a test that uses the processor libs on Windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by Ted Mielczarek
Modified:
13 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

Similar to some of the tests I wrote for Mac and Linux, this lets us use the
processor libs in Windows client unittests. This is useful for ensuring that the
dump generation code produces the expected output in certain circumstances. The
actual test added here isn't very useful, but I have another patch coming right
up that uses this.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/windows/breakpad_client.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/client/windows/unittests/client_tests.gyp View 1 chunk +20 lines, -0 lines 0 comments Download
M src/client/windows/unittests/exception_handler_test.cc View 6 chunks +55 lines, -3 lines 1 comment Download

Messages

Total messages: 2
Ted Mielczarek
13 years, 10 months ago #1
Mark Mentovai
13 years, 10 months ago #2
LGTM

http://breakpad.appspot.com/258001/diff/1/4
File src/client/windows/unittests/exception_handler_test.cc (right):

http://breakpad.appspot.com/258001/diff/1/4#newcode377
Line 377: }
}  // namespace
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted