Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(317)

Issue 257001: Fix some crash bugs in Stackwalker implementations when resolver is NULL (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by Ted Mielczarek
Modified:
13 years, 3 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

Apparently these have existed since this code was written. I just ran into them
while writing a one-off tool that didn't bother to use a resolver.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/processor/stackwalker.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/processor/stackwalker_amd64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/stackwalker_amd64_unittest.cc View 1 chunk +23 lines, -1 line 0 comments Download
M src/processor/stackwalker_arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/processor/stackwalker_arm_unittest.cc View 1 chunk +18 lines, -0 lines 2 comments Download
M src/processor/stackwalker_x86.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/processor/stackwalker_x86_unittest.cc View 1 chunk +20 lines, -0 lines 1 comment Download

Messages

Total messages: 3
Ted Mielczarek
13 years, 3 months ago #1
Mark Mentovai
LGTM. http://breakpad.appspot.com/257001/diff/1/6 File src/processor/stackwalker_arm_unittest.cc (right): http://breakpad.appspot.com/257001/diff/1/6#newcode148 Line 148: EXPECT_TRUE(memcmp(&raw_context, &frame->context, sizeof(raw_context)) == 0); EXPECT_EQ instead? ...
13 years, 3 months ago #2
Ted Mielczarek
13 years, 3 months ago #3
http://breakpad.appspot.com/257001/diff/1/6
File src/processor/stackwalker_arm_unittest.cc (right):

http://breakpad.appspot.com/257001/diff/1/6#newcode148
Line 148: EXPECT_TRUE(memcmp(&raw_context, &frame->context, sizeof(raw_context))
== 0);
On 2011/01/24 19:15:44, Mark Mentovai wrote:
> EXPECT_EQ instead?

I copy/pasted these from elsewhere in the file. I'll fix them all.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted