Issue 255001: Add MinidumpMemoryInfo / MinidumpMemoryInfoList classes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 255001: Add MinidumpMemoryInfo / MinidumpMemoryInfoList classes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by Ted Mielczarek

Modified:
13 years, 3 months ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

Description

I have a Firefox patch that's going to make us write dumps with
MiniDumpWithFullMemoryInfo when possible, so I'd like to make this data avilable
via the processor API for easier analysis. I've modeled the APIs here after the
other classes in minidump.h, let me know if you think there's anything out of
line. We could probably take this further and expose this data to
MinidumpProcessor et. al. if it's present, which might let us make some smarter
decisions about things, but I'm not sure if it's worth it.

Patch Set 1 #

Total comments: 1

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/google_breakpad/processor/minidump.h	View	2 chunks	+71 lines, -0 lines	0 comments	Download
M	src/processor/minidump.cc	View	2 chunks	+260 lines, -0 lines	1 comment	Download
M	src/processor/minidump_dump.cc	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	src/processor/minidump_unittest.cc	View	2 chunks	+57 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Mark Mentovai

13 years, 3 months ago #2

LGTM

http://breakpad.appspot.com/255001/diff/1/3
File src/processor/minidump.cc (right):

http://breakpad.appspot.com/255001/diff/1/3#newcode3441
Line 3441: //
I think for the most part this file uses two blank lines between classes like
here.

3523 too.

Expand All Messages | Collapse All Messages