Issue 25001: Issue 328 - should have constant for VC++ exceptions, and stringify in MinidumpProcessor::GetCrashRe

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 25001: Issue 328 - should have constant for VC++ exceptions, and stringify in MinidumpProcessor::GetCrashRe (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by Ted Mielczarek

Modified:
15 years, 1 month ago

Reviewers:
mochalatte

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Simple patch, adds a constant and stringifies it in the processor.

Here's a dump file with this sort of exception for testing:
http://people.mozilla.com/~tmielczarek/5e121fec-bd44-43ca-8c10-32a6ad21b3c3.dmp

Neal, can you take a look?

Patch Set 1 #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
		src/google_breakpad/common/minidump_exception_win32.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
		src/processor/minidump_processor.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Thanks, Ted

Expand All Messages | Collapse All Messages