Issue 247001: Resize Mac uploader's email text field if necessary due to localization

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 247001: Resize Mac uploader's email text field if necessary due to localization (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by stuart.morgan

Modified:
13 years, 4 months ago

Reviewers:
Mark Mentovai

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/client/mac/sender/crash_report_sender.m	View		1 chunk	+16 lines, -5 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

stuart.morgan

See https://bugzilla.mozilla.org/show_bug.cgi?id=595054 for the bug this fixes.

13 years, 4 months ago #1

Mark Mentovai

13 years, 4 months ago #2

LGTM

http://breakpad.appspot.com/247001/diff/1/2
File src/client/mac/sender/crash_report_sender.m (right):

http://breakpad.appspot.com/247001/diff/1/2#newcode621
Line 621: CGFloat privacyLabelWidthDelta = [privacyLinkLabel_
breakpad_adjustWidthToFit];
80

http://breakpad.appspot.com/247001/diff/1/2#newcode627
Line 627: NSMinX([emailEntryField_ frame]) - kMinControlPadding;
I think it’d read better if the NSMinXs were lined up, and then
kMinControlPadding could be on its own line lined up with the NSMinXs too.

Expand All Messages | Collapse All Messages