Record sent crashes on Mac

[stuart.morgan]

I'll do the other platforms as well; I just wanted to make sure there were no
objections to this approach first.

[Mark Mentovai]

LGTM

http://breakpad.appspot.com/245001/diff/1/2
File src/client/mac/sender/crash_report_sender.m (right):

http://breakpad.appspot.com/245001/diff/1/2#newcode1045
Line 1045: [parameters_ objectForKey:@kReporterMinidumpDirectoryKey];
4-space indent on a continuation line (as you properly did in the next two
statements).

http://breakpad.appspot.com/245001/diff/1/2#newcode1048
Line 1048: NSString *logLine = [NSString stringWithFormat:@"%u,%s\n",
I don’t understand the cast and use of %u.

Why not get rid of the conversion and use %.0f?

http://breakpad.appspot.com/245001/diff/1/2#newcode1057
Line 1057: [logFileHandle writeData:logData];
[logFileHandle closeFile] too, since you don’t control deallocation of
logFileHandle.

[stuart.morgan]

http://breakpad.appspot.com/245001/diff/1/2
File src/client/mac/sender/crash_report_sender.m (right):

http://breakpad.appspot.com/245001/diff/1/2#newcode1045
Line 1045: [parameters_ objectForKey:@kReporterMinidumpDirectoryKey];
On 2010/12/17 17:54:55, Mark Mentovai wrote:
> 4-space indent on a continuation line (as you properly did in the next two
> statements).

Done.

http://breakpad.appspot.com/245001/diff/1/2#newcode1048
Line 1048: NSString *logLine = [NSString stringWithFormat:@"%u,%s\n",
On 2010/12/17 17:54:55, Mark Mentovai wrote:
> Why not get rid of the conversion and use %.0f?

No reason at all :)

http://breakpad.appspot.com/245001/diff/1/2#newcode1057
Line 1057: [logFileHandle writeData:logData];
On 2010/12/17 17:54:55, Mark Mentovai wrote:
> [logFileHandle closeFile] too, since you don’t control deallocation of
> logFileHandle.

Whoops, I didn't notice that I'd forgotten that line. Nice catch.

[Mark Mentovai]

LGTM

http://breakpad.appspot.com/245001/diff/5001/6002
File src/client/mac/Breakpad.xcodeproj/project.pbxproj (right):

http://breakpad.appspot.com/245001/diff/5001/6002#newcode574
Line 574: D2F9A546121383A1002747C1 /* handler_test */ = {isa = PBXFileReference;
explicitFileType = "compiled.mach-o.executable"; includeInIndex = 0; path =
handler_test; sourceTree = BUILT_PRODUCTS_DIR; };
This file wasn’t in the changelist initially and it doesn’t appear to be
related. What’s up?

[stuart.morgan]

On 2010/12/17 20:22:38, Mark Mentovai wrote:
> This file wasn’t in the changelist initially and it doesn’t appear to be
> related. What’s up?

I just forgot to re-revert after the changes. Xcode messes with the project a
bit on launch.