http://breakpad.appspot.com/245001/diff/1/2
File src/client/mac/sender/crash_report_sender.m (right):
http://breakpad.appspot.com/245001/diff/1/2#newcode1045
Line 1045: [parameters_ objectForKey:@kReporterMinidumpDirectoryKey];
On 2010/12/17 17:54:55, Mark Mentovai wrote:
> 4-space indent on a continuation line (as you properly did in the next two
> statements).
Done.
http://breakpad.appspot.com/245001/diff/1/2#newcode1048
Line 1048: NSString *logLine = [NSString stringWithFormat:@"%u,%s\n",
On 2010/12/17 17:54:55, Mark Mentovai wrote:
> Why not get rid of the conversion and use %.0f?
No reason at all :)
http://breakpad.appspot.com/245001/diff/1/2#newcode1057
Line 1057: [logFileHandle writeData:logData];
On 2010/12/17 17:54:55, Mark Mentovai wrote:
> [logFileHandle closeFile] too, since you don’t control deallocation of
> logFileHandle.
Whoops, I didn't notice that I'd forgotten that line. Nice catch.
On 2010/12/17 20:22:38, Mark Mentovai wrote:
> This file wasn’t in the changelist initially and it doesn’t appear to be
> related. What’s up?
I just forgot to re-revert after the changes. Xcode messes with the project a
bit on launch.
Issue 245001: Record sent crashes on Mac
(Closed)
Created 13 years, 9 months ago by stuart.morgan
Modified 13 years, 9 months ago
Reviewers: Mark Mentovai
Base URL: http://google-breakpad.googlecode.com/svn/trunk/
Comments: 7