Issue 244001: Fix MinidumpGenerator::WriteExceptionStream for writing cross-architecture dumps

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 244001: Fix MinidumpGenerator::WriteExceptionStream for writing cross-architecture dumps (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by Ted Mielczarek

Modified:
14 years, 1 month ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

Description

Apparentlhy my test coverage wasn't thorough enough, and WriteExceptionStream
didn't work for cross-architecture dumping. The real useful changes here are in
minidump_generator.cc and crash_generation_server.h, the rest of the patch is
just test changes.

Patch Set 1 #

Total comments: 3

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/client/mac/Breakpad.xcodeproj/project.pbxproj	View	5 chunks	+39 lines, -0 lines	0 comments	Download
M	src/client/mac/crash_generation/crash_generation_client.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/client/mac/crash_generation/crash_generation_server.h	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	src/client/mac/handler/minidump_generator.cc	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	src/client/mac/tests/crash_generation_server_test.cc	View	2 chunks	+123 lines, -1 line	0 comments	Download
M	src/client/mac/tests/minidump_generator_test.cc	View	3 chunks	+2 lines, -92 lines	0 comments	Download
M	src/client/mac/tests/minidump_generator_test_helper.cc	View	1 chunk	+25 lines, -14 lines	0 comments	Download
A	src/client/mac/tests/spawn_child_process.h	View	1 chunk	+148 lines, -0 lines	3 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Mark Mentovai

14 years, 1 month ago #2

LGTM

http://breakpad.appspot.com/244001/diff/1/9
File src/client/mac/tests/spawn_child_process.h (right):

http://breakpad.appspot.com/244001/diff/1/9#newcode32
Line 32: #ifndef GOOGLE_BREAKPAD_CLIENT_MAC_TESTS_SPAWN_CHILD_PROCESS
Blank line before.

http://breakpad.appspot.com/244001/diff/1/9#newcode63
Line 63: #error "This test has not been ported to this CPU architecture."
This isn’t a test.

http://breakpad.appspot.com/244001/diff/1/9#newcode75
Line 75: #error "This test has not been ported to this CPU architecture."
And again.

Expand All Messages | Collapse All Messages