Issue 243001: Allow HTTPUpload to submit zero-byte files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 243001: Allow HTTPUpload to submit zero-byte files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by Ted Mielczarek

Modified:
13 years, 11 months ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

Description

We get a fair amount of crash reports on Windows that fail to submit because we
get a zero-byte minidump file. I suspect most of these are due to
MinidumpWriteDump allocating memory and our process being near or at OOM.
Allowing the zero-byte minidumps to be submitted would at least let us gauge the
size of the problem.

Patch Set 1 #

Patch Set 2 : Without extraneous files #

Total comments: 1

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/common/windows/http_upload.cc	View		3 chunks	+4 lines, -5 lines	1 comment	Download
	M	src/common/windows/http_upload.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Mark Mentovai

13 years, 11 months ago #3

LGTM

http://breakpad.appspot.com/243001/diff/3001/4001
File src/common/windows/http_upload.cc (right):

http://breakpad.appspot.com/243001/diff/3001/4001#newcode341
Line 341: file.seekg(0, ios::beg);
Fix the indent on these two lines while you’re here.

Expand All Messages | Collapse All Messages