Issue 239001: Added null checks to disassembler_x86

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 239001: Added null checks to disassembler_x86

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by Cris Neckar

Modified:
13 years, 4 months ago

Reviewers:
justin, siyangxie, cdn

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Added null checks to disassembler_x86

Patch Set 1 #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/processor/disassembler_x86.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

cdn

13 years, 4 months ago #4

Do we have an example of a failing dump?

Thanks

On 2011/05/06 23:14:42, SiyangXie wrote:
> Hello Cris,
> 
> I want to bring this up because yesterday I tried to release a new processor
> with this CL integrated but found it failed too frequently in production.  It
> seems there are still some null checks missing.

Expand All Messages | Collapse All Messages