Issue 23001: Breakpad: Don't use the deprecated __gnu_cxx::hash_map container. (Closed)
DescriptionModern GNU compilers warn about the #inclusion of <ext/hash_map>; that container is deprecated, and code should use <tr1/unordered_map> instead. However, to stay within the boundaries of C++ '98, it's probably fine just to use plain old std::map. Breakpad uses hash_map in three cases: o The DWARF reader's SectionMap type maps object file section names to data. This map is consulted once per section kind per DWARF compilation unit; it is not performance-critical. o The Mac dump_syms tool uses it to map machine architectures to section maps in Universal binaries. It's hard to imagine there ever being more than two entries in such a map. o The processor's BasicSourceLineResolver uses a hash_map to map file numbers to file names. This is the map that will probably have the most entries, but it's only accessed once per frame, after we've found the frame's line entry. Committed: r393 Patch Set 1 #Patch Set 2 : Breakpad: Don't use the deprecated __gnu_cxx::hash_map container. #
MessagesTotal messages: 4
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
