Issue 229001: Mac breakpad should use internal MD5 implementation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 229001: Mac breakpad should use internal MD5 implementation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by bsmedberg

Modified:
12 years, 2 months ago

Reviewers:
Ted Mielczarek

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Mozilla is having problems on mac Leopard with symbol references to MD5_Update,
MD5_Init, and MD5_Finish coming from libnss3 instead of libcrypto, and then not
being resolved lazily because libnss3 doesn't actually export these symbols.
This is apparently a linker bug, but we want to work around it by using the
internal MD5 implementation instead of the one from libcrypto.

See https://bugzilla.mozilla.org/show_bug.cgi?id=599475

Patch Set 1 #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats			Patch
src/client/mac/Breakpad.xcodeproj/project.pbxproj	View	4 chunks	+4 lines, -0 lines	0 comments	Download
src/common/mac/file_id.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
src/common/mac/macho_id.cc	View	4 chunks	+7 lines, -10 lines	0 comments	Download
src/common/mac/macho_id.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
src/tools/mac/dump_syms/dump_syms.xcodeproj/project.pbxproj	View	4 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

The patch here subsumes this one:
http://breakpad.appspot.com/296001

Expand All Messages | Collapse All Messages