Issue 210001: Stop using libtool

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 210001: Stop using libtool (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by Ted Mielczarek

Modified:
13 years, 6 months ago

Reviewers:
Mark Mentovai, mochalatte

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

Description

Libtool adds a lot of complexity for minimal benefit. I don't think there's any
need for the autoconf build system to produce shared libraries, but someone can
correct me if I'm wrong. Getting rid of libtool means that we'll only build
static libraries for the processor and client. This patch actually makes my
build noticeably faster (probably because libtool is a bulky shell script and
gets invoked for every compile and link). My main impetus for writing this patch
is that I'm compiling Breakpad for Android, and that requires directly link some
object files into the binaries which libtool balks at. With this patch things
work fine.

Patch Set 1 #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	Makefile.am	View	5 chunks	+182 lines, -190 lines	0 comments	Download
M	Makefile.in	View	29 chunks	+611 lines, -742 lines	0 comments	Download
M	aclocal.m4	View	2 chunks	+35 lines, -5 lines	0 comments	Download
A	autotools/compile	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	configure	View	12 chunks	+251 lines, -11259 lines	0 comments	Download
M	configure.ac	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/config.h.in	View	1 chunk	+2 lines, -33 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Mark Mentovai

LGTM. Watch for complaints. There’s probably some user out there that is using this build ...

13 years, 6 months ago #2

Ted Mielczarek

13 years, 6 months ago #4

On 2010/10/05 18:37:57, Mark Mentovai wrote:
> P.S. be sure you’ve tested this on at least Linux and Mac.

Yeah, builds fine on both (and under cygwin as well). As a bonus, this also
fixes --enable-m32 on my 64-bit Ubuntu system, which libtool insisted on
breaking.

Expand All Messages | Collapse All Messages