Issue 206001: Add stack scanning to the amd64 and arm stackwalkers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 206001: Add stack scanning to the amd64 and arm stackwalkers (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by Ted Mielczarek

Modified:
13 years, 7 months ago

Reviewers:
jimb

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

Description

Add stack scanning to the amd64 and arm stackwalkers.

Patch Set 1 #

Total comments: 2

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/processor/stackwalker_amd64.cc	View	2 chunks	+36 lines, -1 line	0 comments	Download
M	src/processor/stackwalker_amd64.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/processor/stackwalker_amd64_unittest.cc	View	1 chunk	+123 lines, -0 lines	0 comments	Download
M	src/processor/stackwalker_arm.cc	View	3 chunks	+64 lines, -17 lines	1 comment	Download
M	src/processor/stackwalker_arm.h	View	1 chunk	+10 lines, -1 line	0 comments	Download
M	src/processor/stackwalker_arm_unittest.cc	View	1 chunk	+123 lines, -0 lines	0 comments	Download
M	src/processor/stackwalker_x86.cc	View	1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

jimb

13 years, 7 months ago #2

LGTM  Yay, monotremes!

http://breakpad.appspot.com/206001/diff/1/5
File src/processor/stackwalker_arm.cc (right):

http://breakpad.appspot.com/206001/diff/1/5#newcode195
Line 195: if (cfi_frame_info.get())
The indentation is wrong here.

http://breakpad.appspot.com/206001/diff/1/8
File src/processor/stackwalker_x86.cc (right):

http://breakpad.appspot.com/206001/diff/1/8#newcode494
Line 494: return NULL;
?? Good catch!

Expand All Messages | Collapse All Messages