Issue 198001: Fix compilation of file_id_unittest.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 198001: Fix compilation of file_id_unittest. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 12 months ago by Lei Zhang (chromium)

Modified:
13 years, 12 months ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Fix compilation of file_id_unittest.

Committed: http://code.google.com/p/google-breakpad/source/detail?r=689

Patch Set 2 : '' #

Created: 13 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/common/linux/file_id_unittest.cc	View	1	4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Lei Zhang (chromium)

Running make check from src/tools/linux/dump_syms spits out: g++ -c ../../../common/linux/file_id_unittest.cc -o file_id_unittest.o -I../../../testing/gtest/include -I../../../testing/gtest -I../../../testing ...

13 years, 12 months ago #1

Mark Mentovai

http://breakpad.appspot.com/198001/diff/1/2 File src/common/linux/file_id_unittest.cc (right): http://breakpad.appspot.com/198001/diff/1/2#newcode90 Line 90: static const size_t kTextSectionSize = 128; Why don’t ...

13 years, 12 months ago #2

Lei Zhang (chromium)

13 years, 12 months ago #3

LGTM

Expand All Messages | Collapse All Messages