Issue 192001: Import linux_syscall_support.h from linux-syscall-support.googlecode.com inst...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 192001: Import linux_syscall_support.h from linux-syscall-support.googlecode.com inst... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 12 months ago by Lei Zhang (chromium)

Modified:
14 years, 12 months ago

Reviewers:
markus

CC:
google-breakpad-dev_googlegroups.com, Ted Mielczarek

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Import linux_syscall_support.h from linux-syscall-support.googlecode.com instead
of using our own copy.

Committed: http://code.google.com/p/google-breakpad/source/detail?r=686

Patch Set 1 #

Created: 14 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/client/linux/crash_generation/crash_generation_client.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/client/linux/handler/exception_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/client/linux/handler/exception_handler_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/client/linux/minidump_writer/directory_reader.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/client/linux/minidump_writer/line_reader.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/client/linux/minidump_writer/linux_dumper.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/client/linux/minidump_writer/minidump_writer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/client/minidump_file_writer.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/common/linux/file_id.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	src/common/linux/linux_syscall_support.h	View	1 chunk	+0 lines, -2949 lines	0 comments	Download
M	src/common/linux/memory.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/processor/testdata/linux_test_app.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/tools/linux/md2core/minidump-2-core.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Lei Zhang (chromium)

codereview doesn't show it, but assuming I did it right, this CL also includes the ...

14 years, 12 months ago #1

LGTM

Expand All Messages | Collapse All Messages