Modify crash_generation_app to use GYP instead of VS .sln file for ease of maintenance.

Hi Hans,

Since you have done some Gyp stuff in Breakpad already, could I get you to
review this change? It extends Gyp to the crash_generation_app so that the build
configuration for this sample app will be more likely to remain up-to-date with
changes to the rest of Breakpad client.

Thanks,

Erik

[Erik Wright]

Hi Neal,

Can I lean on you for another review?

At some point GYP files were added for the rest of the windows client
components. This makes it much easier to build and test these components.
Because crash_generation_app was not being built with GYP, it became stale and
its SLN files had to be modified to build properly.

Now that it is integrated with breakpad_client.gyp, it is more likely to remain
consistent with changes to the rest of the client libraries.

I removed the use of precompiled headers - they were not justified by this small
project. I also fixed one compilation warning for unsigned vs. signed. Other
than that, this is only the minimum for moving to GYP.

TEST="gclient runhooks --force", open breakpad_client.sln, build solution, run
crash_generation_app.

[hansl]

Hey Erik,

Can you give me a quick howto for this app? Trying to launch it but it doesn't
work.

2 nitpicks.

http://breakpad.appspot.com/191001/diff/1/2
File src/client/windows/tests/crash_generation_app/crash_generation_app.cc
(right):

http://breakpad.appspot.com/191001/diff/1/2#newcode33
Line 33: #include
"client/windows/tests/crash_generation_app/crash_generation_app.h"
You're missing an #include here: "client/windows/crash_generation/client_info.h"
The code don't compile without it.

It seems to have been removed when you deleted precompile.h. Why did you remove
it?

http://breakpad.appspot.com/191001/diff/1/6
File src/client/windows/tests/crash_generation_app/crash_generation_app.gyp
(right):

http://breakpad.appspot.com/191001/diff/1/6#newcode56
Line 56: 'SubSystem': '2',
Maybe comment this line. This is not clear that it is a "Windows app" instead of
a console one.

[Erik Wright]

I responded to your comments and also noted that r684 added an include dir for a
dependency that I removed in r685. So I have rolled back r684 as part of this
change (see breakpad_client.gyp).

http://code.google.com/p/google-breakpad/source/detail?r=684
http://code.google.com/p/google-breakpad/source/detail?r=685

http://breakpad.appspot.com/191001/diff/1/2
File src/client/windows/tests/crash_generation_app/crash_generation_app.cc
(right):

http://breakpad.appspot.com/191001/diff/1/2#newcode33
Line 33: #include
"client/windows/tests/crash_generation_app/crash_generation_app.h"
On 2010/09/21 15:23:13, hansl wrote:
> You're missing an #include here:
"client/windows/crash_generation/client_info.h"
> The code don't compile without it.
> 
> It seems to have been removed when you deleted precompile.h. Why did you
remove
> it?

I suspect this was due to a conflict with another of my commits:

http://code.google.com/p/google-breakpad/source/diff?spec=svn695&r=695&format...

Fixed.

http://breakpad.appspot.com/191001/diff/1/6
File src/client/windows/tests/crash_generation_app/crash_generation_app.gyp
(right):

http://breakpad.appspot.com/191001/diff/1/6#newcode56
Line 56: 'SubSystem': '2',
On 2010/09/21 15:23:13, hansl wrote:
> Maybe comment this line. This is not clear that it is a "Windows app" instead
of
> a console one.

Done.

[Erik Wright]

On 2010/09/21 15:23:12, hansl wrote:
> Hey Erik,
> 
> Can you give me a quick howto for this app? Trying to launch it but it doesn't
> work.
> 
> 2 nitpicks.
> 
> http://breakpad.appspot.com/191001/diff/1/2
> File src/client/windows/tests/crash_generation_app/crash_generation_app.cc
> (right):
> 
> http://breakpad.appspot.com/191001/diff/1/2#newcode33
> Line 33: #include
> "client/windows/tests/crash_generation_app/crash_generation_app.h"
> You're missing an #include here:
"client/windows/crash_generation/client_info.h"
> The code don't compile without it.
> 
> It seems to have been removed when you deleted precompile.h. Why did you
remove
> it?
> 
> http://breakpad.appspot.com/191001/diff/1/6
> File src/client/windows/tests/crash_generation_app/crash_generation_app.gyp
> (right):
> 
> http://breakpad.appspot.com/191001/diff/1/6#newcode56
> Line 56: 'SubSystem': '2',
> Maybe comment this line. This is not clear that it is a "Windows app" instead
of
> a console one.

HOWTO:

Launch the crash_generation_app and select "Start Server".

Then launch another instance (not in debugger) and it will connect to the server
of the second instance (maybe you need to tell it to do so from the menu?). Then
you can select a crash type and it will die, but a crash dump will be recorded
by the server instance.

[hansl]

LGTM with 1 small change to do.

Thanks for this issue.

http://breakpad.appspot.com/191001/diff/1009/16005
File src/client/windows/tests/crash_generation_app/crash_generation_app.gyp
(right):

http://breakpad.appspot.com/191001/diff/1009/16005#newcode57
Line 57: },
There's a tab here. Should use only spaces.

[Erik Wright]

Done and committed in r696.

http://breakpad.appspot.com/191001/diff/1009/16005
File src/client/windows/tests/crash_generation_app/crash_generation_app.gyp
(right):

http://breakpad.appspot.com/191001/diff/1009/16005#newcode57
Line 57: },
On 2010/09/21 17:12:10, hansl wrote:
> There's a tab here. Should use only spaces.

Done. Thanks.