Issue 181001: Fix PDBSourceLineWriter::GetModuleInfo's CPU detection

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 181001: Fix PDBSourceLineWriter::GetModuleInfo's CPU detection (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by Ted Mielczarek

Modified:
14 years, 1 month ago

Reviewers:
mochalatte

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

Description

This fixes issue 370. PDBSourceLineWriter::GetModuleInfo is using get_platform
to try to determine the target CPU, but it's doing it wrong (as explained in
that issue). We should be using get_machineType, but I had to figure out what
the heck that method was doing, because the docs are wrong. This patch fixes it
to work properly. Also, we should probably add some unit tests for the Win32
dumper.

Patch Set 1 #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/common/windows/pdb_source_line_writer.cc	View		1 chunk	+19 lines, -5 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM
gotta love it when the official docs are wrong

Expand All Messages | Collapse All Messages