Issue 18009: Process STABS + DWARF, run in PPC machines

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 18009: Process STABS + DWARF, run in PPC machines (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by mochalatte

Modified:
15 years, 2 months ago

Reviewers:
stuart.morgan

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/common/mac/dump_syms.mm	View		2 chunks	+11 lines, -4 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

mochalatte

Hi Stuart This fix fixes dump_syms to properly run on PPC machines, and also to ...

15 years, 3 months ago #1

stuart.morgan

15 years, 3 months ago #2

LGTM

http://breakpad.appspot.com/18009/diff/1/2
File src/common/mac/dump_syms.mm (right):

http://breakpad.appspot.com/18009/diff/1/2#newcode327
Line 327: bool loadedDWARF = NO;
s/bool/BOOL/

http://breakpad.appspot.com/18009/diff/1/2#newcode333
Line 333: return loadedDWARF ? YES : loadedStabs;
Probably clearer as:
return loadedDWARF || loadedStabs

Expand All Messages | Collapse All Messages