Issue 178001: Linux FileID should work with ELFCLASS32 and ELFCLASS64 regardless of what's native

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 178001: Linux FileID should work with ELFCLASS32 and ELFCLASS64 regardless of what's native (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by Mark Mentovai

Modified:
14 years, 1 month ago

Reviewers:
Ted Mielczarek, jimb

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Linux FileID should work with ELFCLASS32 and ELFCLASS64 regardless of what's
native.

BUG=399
TEST=none

Committed r677

Patch Set 1 #

Total comments: 3

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/common/linux/file_id.cc	View		2 chunks	+56 lines, -25 lines	2 comments	Download
	M	src/common/linux/file_id_unittest.cc	View		2 chunks	+67 lines, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Ted Mielczarek

14 years, 1 month ago #3

LGTM

http://breakpad.appspot.com/178001/diff/1/2
File src/common/linux/file_id.cc (right):

http://breakpad.appspot.com/178001/diff/1/2#newcode73
Line 73: template<typename ElfClass>
Neat template trick. I couldn't sort out a decent way to handle both 32 and
64-bit without duplicating the code when I originally wrote it.

http://breakpad.appspot.com/178001/diff/1/2#newcode84
Line 84: assert(my_strncmp(elf_base, ELFMAG, SELFMAG) == 0);
Is this just for sanity's sake?

http://breakpad.appspot.com/178001/diff/1/3
File src/common/linux/file_id_unittest.cc (right):

http://breakpad.appspot.com/178001/diff/1/3#newcode92
Line 92: struct ElfishElf {
Elvish? Elfen? :)

Expand All Messages | Collapse All Messages